Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5326 - users can now select proof from gallery in "add price" page #5679

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • A recent PR added the possibility, from a proof detail page, to add prices to that already existing proof.
  • In the current PR, we're also able to select an already existing proof from the "add prices" page.

Screenshot

Screenshot_20241009_134951

Fixes bug(s)

Impacted files

  • image_crop_page.dart: now we can force the image source
  • price_model.dart: now we can set a proof after init time
  • price_proof_card.dart: now we can select the proof image among "camera", "gallery" and "my proofs"; minor refactoring
  • prices_proofs_page.dart: added a "select proof?" parameter to pop the selected proof if needed
  • user_preferences_account.dart: minor refactoring

Impacted files:
* `image_crop_page.dart`: now we can force the image source
* `price_model.dart`: now we can set a proof after init time
* `price_proof_card.dart`: now we can select the proof image among "camera", "gallery" and "my proofs"; minor refactoring
* `prices_proofs_page.dart`: added a "select proof?" parameter to pop the selected proof if needed
* `user_preferences_account.dart`: minor refactoring
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.35135% with 73 lines in your changes missing coverage. Please review.

Project coverage is 6.80%. Comparing base (4d9c7fc) to head (c9f5871).
Report is 354 commits behind head on develop.

Files with missing lines Patch % Lines
.../smooth_app/lib/pages/prices/price_proof_card.dart 0.00% 49 Missing ⚠️
...kages/smooth_app/lib/pages/prices/price_model.dart 0.00% 13 Missing ⚠️
...mooth_app/lib/pages/prices/prices_proofs_page.dart 12.50% 7 Missing ⚠️
packages/smooth_app/lib/pages/image_crop_page.dart 0.00% 3 Missing ⚠️
...ib/pages/preferences/user_preferences_account.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5679      +/-   ##
==========================================
- Coverage     9.54%   6.80%   -2.75%     
==========================================
  Files          325     404      +79     
  Lines        16411   21550    +5139     
==========================================
- Hits          1567    1466     -101     
- Misses       14844   20084    +5240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@monsieurtanuki monsieurtanuki merged commit 449ae5a into openfoodfacts:develop Oct 9, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow to pick a price proof from your online proof gallery Prices images improvement
3 participants